From ff59c040f59de0f3f75170ce9942073d63706440 Mon Sep 17 00:00:00 2001
From: Chneemann <Andre-Ke@gmx.de>
Date: Thu, 8 Aug 2024 04:43:30 +0200
Subject: [PATCH] bugfixes & clean code

---
 frontend/src/app/components/auth/auth.component.html      | 5 -----
 frontend/src/app/components/auth/auth.component.scss      | 2 +-
 .../auth/forgot-password/forgot-password.component.ts     | 8 ++------
 frontend/src/app/components/auth/login/login.component.ts | 4 +---
 .../app/components/auth/register/register.component.ts    | 4 +---
 .../auth/verify-email/verify-email.component.ts           | 4 +---
 6 files changed, 6 insertions(+), 21 deletions(-)

diff --git a/frontend/src/app/components/auth/auth.component.html b/frontend/src/app/components/auth/auth.component.html
index 741d4ff..82c7710 100644
--- a/frontend/src/app/components/auth/auth.component.html
+++ b/frontend/src/app/components/auth/auth.component.html
@@ -33,11 +33,6 @@
       !isUserEmailValid(authData.mail.toLowerCase())) {
       <p>This is not a valid email format</p>
       }}
-      <!-- <div *ngIf="errorService.error$ | async as errors">
-        <div *ngIf="errors?.['mail']">
-          <p>{{ errors["mail"] }}</p>
-        </div>
-      </div> -->
     </div>
     <app-btn-large
       [value]="'Sign Up'"
diff --git a/frontend/src/app/components/auth/auth.component.scss b/frontend/src/app/components/auth/auth.component.scss
index 81e3e9e..3ec83a6 100644
--- a/frontend/src/app/components/auth/auth.component.scss
+++ b/frontend/src/app/components/auth/auth.component.scss
@@ -51,5 +51,5 @@ form {
   position: absolute;
   bottom: 0;
   padding: 6px;
-  width: 62%;
+  width: 57%;
 }
diff --git a/frontend/src/app/components/auth/forgot-password/forgot-password.component.ts b/frontend/src/app/components/auth/forgot-password/forgot-password.component.ts
index 0bc2414..9b1f96e 100644
--- a/frontend/src/app/components/auth/forgot-password/forgot-password.component.ts
+++ b/frontend/src/app/components/auth/forgot-password/forgot-password.component.ts
@@ -76,9 +76,7 @@ export class ForgotPasswordComponent {
       this.errorService.clearError();
     } catch (error) {
       this.sendMailSuccess = false;
-      const errorMessage =
-        error instanceof Error ? error.message : 'An unknown error occurred';
-      this.errorService.errorMsg(errorMessage);
+      this.errorService.handleError(error);
     }
   }
 
@@ -96,9 +94,7 @@ export class ForgotPasswordComponent {
       this.queryEmailSuccess = true;
       this.errorService.clearError();
     } catch (error) {
-      const errorMessage =
-        error instanceof Error ? error.message : 'An unknown error occurred';
-      this.errorService.errorMsg(errorMessage);
+      this.errorService.handleError(error);
     }
   }
 }
diff --git a/frontend/src/app/components/auth/login/login.component.ts b/frontend/src/app/components/auth/login/login.component.ts
index 985dcc2..95e6a4b 100644
--- a/frontend/src/app/components/auth/login/login.component.ts
+++ b/frontend/src/app/components/auth/login/login.component.ts
@@ -45,9 +45,7 @@ export class LoginComponent {
         this.router.navigate(['/browse/']);
         this.errorService.clearError();
       } catch (error) {
-        const errorMessage =
-          error instanceof Error ? error.message : 'An unknown error occurred';
-        this.errorService.errorMsg(errorMessage);
+        this.errorService.handleError(error);
       }
     }
   }
diff --git a/frontend/src/app/components/auth/register/register.component.ts b/frontend/src/app/components/auth/register/register.component.ts
index e597d08..f0c978d 100644
--- a/frontend/src/app/components/auth/register/register.component.ts
+++ b/frontend/src/app/components/auth/register/register.component.ts
@@ -55,9 +55,7 @@ export class RegisterComponent {
         this.registrationSuccess = true;
         this.errorService.clearError();
       } catch (error) {
-        const errorMessage =
-          error instanceof Error ? error.message : 'An unknown error occurred';
-        this.errorService.errorMsg(errorMessage);
+        this.errorService.handleError(error);
       }
     }
   }
diff --git a/frontend/src/app/components/auth/verify-email/verify-email.component.ts b/frontend/src/app/components/auth/verify-email/verify-email.component.ts
index 6ce68ad..29d79b3 100644
--- a/frontend/src/app/components/auth/verify-email/verify-email.component.ts
+++ b/frontend/src/app/components/auth/verify-email/verify-email.component.ts
@@ -45,9 +45,7 @@ export class VerifyEmailComponent {
       this.errorService.clearError();
     } catch (error) {
       this.verified = false;
-      const errorMessage =
-        error instanceof Error ? error.message : 'An unknown error occurred';
-      this.errorService.errorMsg(errorMessage);
+      this.errorService.handleError(error);
     }
   }
 }