From 14bb6c520ce58ad909840334a85253d689bbeacf Mon Sep 17 00:00:00 2001
From: Chneemann <andre-kempf@mailbox.org>
Date: Wed, 7 May 2025 10:52:28 +0200
Subject: [PATCH] feat: create EmailRequestComponent and integrate into
 ForgotPasswordComponent to separate responsibilities

---
 .../email-request.component.html              | 36 ++++++++++
 .../email-request.component.scss              |  3 +
 .../email-request.component.spec.ts           | 23 +++++++
 .../email-request/email-request.component.ts  | 66 +++++++++++++++++++
 .../forgot-password.component.html            | 45 +------------
 .../forgot-password.component.ts              | 13 +++-
 6 files changed, 143 insertions(+), 43 deletions(-)
 create mode 100644 frontend/src/app/components/auth/forgot-password/email-request/email-request.component.html
 create mode 100644 frontend/src/app/components/auth/forgot-password/email-request/email-request.component.scss
 create mode 100644 frontend/src/app/components/auth/forgot-password/email-request/email-request.component.spec.ts
 create mode 100644 frontend/src/app/components/auth/forgot-password/email-request/email-request.component.ts

diff --git a/frontend/src/app/components/auth/forgot-password/email-request/email-request.component.html b/frontend/src/app/components/auth/forgot-password/email-request/email-request.component.html
new file mode 100644
index 0000000..fc207e7
--- /dev/null
+++ b/frontend/src/app/components/auth/forgot-password/email-request/email-request.component.html
@@ -0,0 +1,36 @@
+<div class="note">
+  <p>We will send you an email with instructions to reset your password.</p>
+</div>
+
+<form [formGroup]="form" (ngSubmit)="onSubmit()">
+  <div class="email-field">
+    <input
+      formControlName="email"
+      type="email"
+      id="email"
+      placeholder="Email Address"
+      autocomplete="email"
+      [class.error-border]="
+        form.controls['email'].invalid && form.controls['email'].touched
+      "
+    />
+    <img class="email-icon" src="./assets/img/email.svg" />
+  </div>
+
+  <div class="error-container">
+    @if (form.controls['email'].touched && form.controls['email'].invalid) {
+    <div class="error-msg">
+      @if (form.controls['email'].errors?.['required']) {
+      <p role="alert">Please enter your email</p>
+      } @if (form.controls['email'].errors?.['invalidEmailFormat']) {
+      <p role="alert">This is not a valid email format</p>
+      }
+    </div>
+    }
+  </div>
+
+  <app-btn-large
+    [value]="'Send Email'"
+    [disabled]="form.invalid || form.disabled"
+  ></app-btn-large>
+</form>
diff --git a/frontend/src/app/components/auth/forgot-password/email-request/email-request.component.scss b/frontend/src/app/components/auth/forgot-password/email-request/email-request.component.scss
new file mode 100644
index 0000000..7ccd3a4
--- /dev/null
+++ b/frontend/src/app/components/auth/forgot-password/email-request/email-request.component.scss
@@ -0,0 +1,3 @@
+@use "./../../../../../assets/style/backgrounds.scss" as *;
+@use "./../../../../../assets/style/form.scss" as *;
+@use "./../../../../../assets/style/auth-layout.scss" as *;
diff --git a/frontend/src/app/components/auth/forgot-password/email-request/email-request.component.spec.ts b/frontend/src/app/components/auth/forgot-password/email-request/email-request.component.spec.ts
new file mode 100644
index 0000000..3b42912
--- /dev/null
+++ b/frontend/src/app/components/auth/forgot-password/email-request/email-request.component.spec.ts
@@ -0,0 +1,23 @@
+import { ComponentFixture, TestBed } from '@angular/core/testing';
+
+import { EmailRequestComponent } from './email-request.component';
+
+describe('EmailRequestComponent', () => {
+  let component: EmailRequestComponent;
+  let fixture: ComponentFixture<EmailRequestComponent>;
+
+  beforeEach(async () => {
+    await TestBed.configureTestingModule({
+      imports: [EmailRequestComponent]
+    })
+    .compileComponents();
+
+    fixture = TestBed.createComponent(EmailRequestComponent);
+    component = fixture.componentInstance;
+    fixture.detectChanges();
+  });
+
+  it('should create', () => {
+    expect(component).toBeTruthy();
+  });
+});
diff --git a/frontend/src/app/components/auth/forgot-password/email-request/email-request.component.ts b/frontend/src/app/components/auth/forgot-password/email-request/email-request.component.ts
new file mode 100644
index 0000000..8f2297f
--- /dev/null
+++ b/frontend/src/app/components/auth/forgot-password/email-request/email-request.component.ts
@@ -0,0 +1,66 @@
+import { Component, EventEmitter, OnInit, Output } from '@angular/core';
+import { BtnLargeComponent } from '../../../../shared/components/buttons/btn-large/btn-large.component';
+import {
+  FormBuilder,
+  FormGroup,
+  FormsModule,
+  ReactiveFormsModule,
+  Validators,
+} from '@angular/forms';
+import { ErrorService } from '../../../../services/error.service';
+import { AuthService } from '../../../../services/auth.service';
+import { emailFormatValidator } from '../../../../validators/email-format.validator';
+
+@Component({
+  selector: 'app-email-request',
+  imports: [BtnLargeComponent, FormsModule, ReactiveFormsModule],
+  templateUrl: './email-request.component.html',
+  styleUrl: './email-request.component.scss',
+})
+export class EmailRequestComponent implements OnInit {
+  @Output() submittedChange = new EventEmitter<boolean>();
+
+  form: FormGroup = new FormGroup({});
+
+  constructor(
+    private errorService: ErrorService,
+    private authService: AuthService,
+    private fb: FormBuilder
+  ) {}
+
+  ngOnInit(): void {
+    this.createForm();
+  }
+
+  async onSubmit(): Promise<void> {
+    if (this.form.valid) {
+      const body = this.createFormRequestBody();
+      this.form.disable();
+
+      try {
+        await this.authService.forgotPassword(body);
+        this.emitFormSubmitted();
+      } catch (error) {
+        this.errorService.handleError(error);
+      } finally {
+        this.form.enable();
+      }
+    }
+  }
+
+  private createForm(): void {
+    this.form = this.fb.group({
+      email: ['', [Validators.required, emailFormatValidator()]],
+    });
+  }
+
+  private createFormRequestBody(): { email: string } {
+    return {
+      email: this.form.value.email.toLowerCase(),
+    };
+  }
+
+  private emitFormSubmitted(): void {
+    this.submittedChange.emit(true);
+  }
+}
diff --git a/frontend/src/app/components/auth/forgot-password/forgot-password.component.html b/frontend/src/app/components/auth/forgot-password/forgot-password.component.html
index 0890840..e20c37c 100644
--- a/frontend/src/app/components/auth/forgot-password/forgot-password.component.html
+++ b/frontend/src/app/components/auth/forgot-password/forgot-password.component.html
@@ -2,48 +2,9 @@
   <div class="content">
     <div class="headline">Forgot your password?</div>
     @if (!queryEmail && !sendEmailSuccess && !queryEmailSuccess) {
-    <div class="note">
-      <p>We will send you an email with instructions to reset your password.</p>
-    </div>
-    <form
-      #taskForm="ngForm"
-      (ngSubmit)="onSubmit(taskForm, email)"
-      onsubmit="return false"
-    >
-      <div class="email-field">
-        <input
-          type="email"
-          id="email"
-          name="email"
-          #email="ngModel"
-          placeholder="Email Address"
-          class="custom-input"
-          autocomplete="email"
-          [(ngModel)]="authData.email"
-          [class.error-border]="
-            (!email.valid && email.touched) ||
-            (email.touched &&
-              !isUserEmailValid(authData.email.toLowerCase()) &&
-              authData.email.length > 0)
-          "
-          (click)="this.errorService.clearError()"
-          required
-        />
-        <img class="email-icon" src="./assets/img/email.svg" />
-      </div>
-      <div class="error-msg">
-        @if (!email.valid && email.touched) {
-        <p>Please enter your email</p>
-        } @else { @if (email.touched && authData.email.length > 0 &&
-        !isUserEmailValid(authData.email.toLowerCase())) {
-        <p>This is not a valid email format</p>
-        }}
-      </div>
-      <app-btn-large
-        [value]="'Send Email'"
-        [disabled]="!isUserEmailValid(authData.email) || authData.send"
-      ></app-btn-large>
-    </form>
+    <app-email-request
+      (submittedChange)="submittedChange($event)"
+    ></app-email-request>
     } @else { @if (sendEmailSuccess) {
     <div class="note">
       <p>
diff --git a/frontend/src/app/components/auth/forgot-password/forgot-password.component.ts b/frontend/src/app/components/auth/forgot-password/forgot-password.component.ts
index f500b45..d5745d0 100644
--- a/frontend/src/app/components/auth/forgot-password/forgot-password.component.ts
+++ b/frontend/src/app/components/auth/forgot-password/forgot-password.component.ts
@@ -5,11 +5,18 @@ import { FormsModule, NgForm } from '@angular/forms';
 import { ActivatedRoute, Params, RouterLink } from '@angular/router';
 import { AuthService } from '../../../services/auth.service';
 import { ErrorService } from '../../../services/error.service';
+import { EmailRequestComponent } from './email-request/email-request.component';
 
 @Component({
   selector: 'app-forgot-password',
   standalone: true,
-  imports: [CommonModule, BtnLargeComponent, FormsModule, RouterLink],
+  imports: [
+    CommonModule,
+    BtnLargeComponent,
+    FormsModule,
+    RouterLink,
+    EmailRequestComponent,
+  ],
   templateUrl: './forgot-password.component.html',
   styleUrl: './forgot-password.component.scss',
 })
@@ -43,6 +50,10 @@ export class ForgotPasswordComponent implements OnInit {
     this.handleQueryParams();
   }
 
+  submittedChange(value: boolean): void {
+    this.sendEmailSuccess = value;
+  }
+
   /**
    * Subscribes to query parameters and sets internal flags based on them.
    */