From a659bb98aed54be3c453ceca6e4bc58e6941c977 Mon Sep 17 00:00:00 2001 From: Chneemann Date: Thu, 28 Mar 2024 08:13:27 +0100 Subject: [PATCH] clean code --- .../contact-detail.component.html | 31 +++++++++++++------ .../contact-detail.component.ts | 2 +- .../contacts/contacts.component.html | 2 +- .../components/contacts/contacts.component.ts | 4 +-- 4 files changed, 25 insertions(+), 14 deletions(-) diff --git a/src/app/components/contacts/contact-detail/contact-detail.component.html b/src/app/components/contacts/contact-detail/contact-detail.component.html index 4c3f303..45709d3 100644 --- a/src/app/components/contacts/contact-detail/contact-detail.component.html +++ b/src/app/components/contacts/contact-detail/contact-detail.component.html @@ -4,28 +4,31 @@
Better with a team
- @if (paramsId) { + @if (currentUserId) {
- {{ userService.displayUserDetails(paramsId, "initials") }} + {{ userService.displayUserDetails(currentUserId, "initials") }}
- {{ userService.displayUserDetails(paramsId, "firstName") }} - {{ userService.displayUserDetails(paramsId, "lastName") }} + {{ userService.displayUserDetails(currentUserId, "firstName") }} + {{ userService.displayUserDetails(currentUserId, "lastName") }}
diff --git a/src/app/components/contacts/contact-detail/contact-detail.component.ts b/src/app/components/contacts/contact-detail/contact-detail.component.ts index fd50444..360588d 100644 --- a/src/app/components/contacts/contact-detail/contact-detail.component.ts +++ b/src/app/components/contacts/contact-detail/contact-detail.component.ts @@ -12,7 +12,7 @@ import { ContactsComponent } from '../contacts.component'; styleUrl: './contact-detail.component.scss', }) export class ContactDetailComponent { - @Input() paramsId: string = ''; + @Input() currentUserId: string = ''; constructor(public userService: UserService) {} } diff --git a/src/app/components/contacts/contacts.component.html b/src/app/components/contacts/contacts.component.html index b507682..a441231 100644 --- a/src/app/components/contacts/contacts.component.html +++ b/src/app/components/contacts/contacts.component.html @@ -68,5 +68,5 @@ } }
- + diff --git a/src/app/components/contacts/contacts.component.ts b/src/app/components/contacts/contacts.component.ts index e5309ff..8c29df2 100644 --- a/src/app/components/contacts/contacts.component.ts +++ b/src/app/components/contacts/contacts.component.ts @@ -16,7 +16,7 @@ export class ContactsComponent { allUsers: User[] = []; usersFirstLetter: string[] = []; usersByFirstLetter: { [key: string]: string[] } = {}; - paramsId: string = ''; + currentUserId: string = ''; constructor(public userService: UserService, private route: ActivatedRoute) { this.userService.subUserList().subscribe(() => { @@ -34,7 +34,7 @@ export class ContactsComponent { routeUserId() { if (this.route.params.subscribe()) { this.route.params.subscribe((params) => { - this.paramsId = params['id']; + this.currentUserId = params['id']; }); } }